✨ A little refactor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonShiki
requested changes
Oct 29, 2023
There was a problem hiding this comment.
- the code style problem introduced by prettier is absolutely a disaster... I will specifically note all the places where I need to change the prettier configuration.
- the l10n part can be replaced by
formatMessage. Using standardized solutions can pave the way for subsequent i18n.
anyway, some of the changes in this pull request are very exciting. thank you very much for your contribution to this project!
SimonShiki
reviewed
Oct 29, 2023
SimonShiki
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
getBlocklyInstancemethod (removed unnecessary alternative method)